Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG/CHANGELOG-3.4.md: update changelog for gRPC metadata printing #18316

Merged
merged 1 commit into from
Jul 14, 2024
Merged

CHANGELOG/CHANGELOG-3.4.md: update changelog for gRPC metadata printing #18316

merged 1 commit into from
Jul 14, 2024
+3 −0

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we update the changelog for gRPC metadata printing in release 3.4 which is mainly a backport from PR #18311.

@k8s-ci-robot
Copy link

Hi @mohamedawnallah. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mohamedawnallah mohamedawnallah mentioned this pull request Jul 13, 2024
Closed
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.

Project coverage is 68.97%. Comparing base (eeeb7e0) to head (575fff8).
Report is 4 commits behind head on main.

❗ Current head 575fff8 differs from pull request most recent head 4bf1861

Please upload reports for the commit 4bf1861 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/embed/config_logging.go 51.53% <11.11%> (+0.29%) ⬆️

... and 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18316      +/-   ##
==========================================
- Coverage   69.00%   68.97%   -0.03%     
==========================================
  Files         417      417              
  Lines       35332    35333       +1     
==========================================
- Hits        24380    24371       -9     
- Misses       9540     9554      +14     
+ Partials     1412     1408       -4

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeeb7e0...4bf1861. Read the comment docs.

jmhbnz
jmhbnz requested changes Jul 13, 2024
View reviewed changes
CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
@mohamedawnallah mohamedawnallah force-pushed the changelog-3.4-fmtgRPCMetadata branch 2 times, most recently from b162b60 to 07a599f Compare July 13, 2024 23:06
ahrtr
ahrtr reviewed Jul 14, 2024
View reviewed changes
CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
jmhbnz
jmhbnz reviewed Jul 14, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo to fix then this is good to do :)

CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
@mohamedawnallah
CHANGELOG/CHANGELOG-3.4.md: update changelog
4bf1861 
In this commit, we update the changelog for gRPC
metadata printing in release 3.4 which is mainly
a backport from PR etcd-io#18311.

Signed-off-by: Mohamed Awnallah <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mohamedawnallah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 993a1f7 into etcd-io:main Jul 14, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohamedawnallah @k8s-ci-robot @codecov-commenter @ahrtr @jmhbnz